Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): scale tabs to the height of tab group #11520

Closed
wants to merge 1 commit into from
Closed

fix(tabs): scale tabs to the height of tab group #11520

wants to merge 1 commit into from

Conversation

CDDelta
Copy link

@CDDelta CDDelta commented May 26, 2018

Implements the fix by @RobJacobs to correctly scale the contents of mat-tab-group to the group's height. Replaces PR #9180.

Fixes #4591

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 26, 2018
@darkbasic
Copy link

There was no reason to open a new PR, you can always force push to override any mistake ;)

@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels May 29, 2018
@ngbot
Copy link

ngbot bot commented May 29, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: build" is failing
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@josephperrott josephperrott removed the action: merge The PR is ready for merge by the caretaker label May 30, 2018
@josephperrott
Copy link
Member

@crisbeto Will we have issues with backface-visibility here?

@crisbeto
Copy link
Member

We might @josephperrott. This is one of the places that we removed it from in #10026.

@josephperrott josephperrott added the needs investigation A member of the team needs to do further investigation to determine the root cause label May 31, 2018
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@andrewseguin andrewseguin added the P4 A relatively minor issue that is not relevant to core functions label May 30, 2019
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 16, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs investigation A member of the team needs to do further investigation to determine the root cause P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tabs] Md-tab height: 100% does not give all height of group
7 participants